GFlisch / Arc4u.Guidance.Doc

Other
5 stars 1 forks source link

Add a WPF project: "nativeAppDisplayName" is identical for "DEV" and "DEVELOPMENT" #183

Closed bibheist-unity closed 6 months ago

bibheist-unity commented 1 year ago

Describe the bug When the guidance is used to add a new WPF project, the JSON configuration files generated in the folder "OAuth2" include the same value for the property "nativeAppDisplayName" for the environment "DEV" and "DEVELOPMENT".

Therefore, if the JSON files for DEV and DEVELOPMENT are submitted for ADFS registration, the last submitted one will be refused because ADFS raises an exception due to the duplication of the application name.

To Reproduce Steps to reproduce the behavior:

  1. Open a solution initiated by Guidance
  2. Add a new WPF project
  3. Open the JSON configuration files present in the folder "OAuth2" for DEV and DEVELOPMENT

Expected behavior Ideally, the value for the property "nativeAppDisplayName" should contains the name of the application including a suffix (ex: "LocalHost") for the environment "DEVELOPMENT". This avoids any ambiguity.

Desktop (please complete the following information):

vvdb-architecture commented 1 year ago

The native application display name is local to the application group. As long as the application group name is different, the native application name can be anything as long as it is unique within the ADFS group.

Please show exactly what will be refused and how you know that it will be refused.

bibheist-unity commented 1 year ago

Of course!

The automated e-mail sent back by ADFS includes this error message:

`Executing RegisterNativeApplication RedirectUri = urn://outageplanningtool.basic.authentication Native application clientId : 3a18cf4f-1a68-4016-8931-028257c0c140 Executing RegisterNativeApplication RedirectUri = http://localhost/ MSIS7605: The name of the client must be unique across all clients. + CategoryInfo : InvalidData: (Microsoft.Ident...ientApplication: NativeClientApplication) [Add-AdfsNativeClientApplication], StorageConstra intException

GFlisch commented 1 year ago

I propose to discuss about this in the monthly meeting.

Do we add or not the environment name in the nativeAppDisplayName?

@bibheist-unity, is it ok for you to proceed like this?

bibheist-unity commented 1 year ago

Yes ! Of course.Le 18 juil. 2023 à 08:01, GFlisch @.***> a écrit : I propose to discuss about this in the monthly meeting. Do we add or not the environment name in the nativeAppDisplayName? @bibheist-unity, is it ok for you to proceed like this?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

rdarko commented 10 months ago

To be checked if it can be solved by changing the template only. If not, it should be moved to the bugfixing sprint

GFlisch commented 10 months ago

Will be fixed in the version 14.