GFlisch / Arc4u.Guidance.Doc

Other
5 stars 1 forks source link

Verify/create the 'Rules' and 'Validators' folders when creating a new BL class #185

Closed SSantiagoDev closed 1 year ago

SSantiagoDev commented 1 year ago

Description of the bug An architect created a new solution on his machine, committed it to Git, then I took it on my machine. Git doesn't save an empty folder. So when pushing the new solution to Git, the 'Rules' and 'Validators' folders from the Business project, they only "exist" in the csproj, but not physically. When we ask to create a new BL class, a check should be made to be sure that these folders exist (and if not, create them). The BL class is not created and there is no error message.

To Reproduce

  1. Create a new solution with the Guidance
  2. Commit to Git
  3. Create a new domain entity
  4. Create a new BL class

Expected behavior The BL class should be created. Not the case currently with this configuration.

Screenshots image The folders need to be created manually to be able to create the BL class: image

Desktop:

GFlisch commented 1 year ago

Hi @SSantiagoDev, I have done a test (by deleting the Rules and Validators) folders based on the next code that will be released. But this one has not changed for me. As the Guidance is not generating any Rules, indeed the Rules folder is not created but the Validators one well.

Image

As you can see here, the Settlement validators where well added below the created folder Logic\Validators.

I will not close this and propose that you keep an eye on this when the new version is released.