GFlisch / Arc4u.Guidance.Doc

Other
5 stars 1 forks source link

(Improvement) Guidance 2022.2.1.9 17/10/2022: Align content of the OAuth2.Settings section in appsettings.[Environment].json #56

Closed vvdb-architecture closed 2 years ago

vvdb-architecture commented 2 years ago

When generating Yarp, the following content is added for OAuth2.Settings (shown for Localhost):

  "OAuth2.Settings": {
    "ProviderId": "Adal",
    "ApplicationKey": "The application key used to identify the application to others.",
    "ServiceApplicationId": "https://happyflow.localhost.host",
    "Authority": "https://adfsdev.belgrid.net/adfs",
    "AuthenticationType": "OAuth2Bearer"
  },

When generating a service, the following content is added for OAuth2.Settings:

  "OAuth2.Settings": {
    "ProviderId": "Adal",
    "ClientId": null,
    "ApplicationKey": "The application key used to identify the application to others.",
    "Authority": "https://adfsdev.belgrid.net/adfs",
    "ServiceApplicationId": "https://happyflow.localhost.host"
  },

The latter is missing AuthenticationTyp and the former is including an unnecessary ClientId.

GFlisch commented 2 years ago

Code fixed => new build required.