search

GFlisch / Arc4u

Apache License 2.0
23 stars 18 forks source link

(Arc4u all versions) Created NuGet package name does not match project name Arc4u.Standard.Configuration.Store #120

Closed HaGGi13 closed 5 months ago

HaGGi13 commented 5 months ago

Describe the bug

First things first, I'm not sure if this is a bug, but an inconsistency for sure.

The solution contains a project named Arc4u.Standard.Configuration.Store, but the out of it created NuGet package is named Arc4u.Configuration.Store. This does not follow the name convention of all other projects within the solution, that the generated NuGet package has the same name like the *.csproj file.

IMHO this is misleading for any contributors and users who want to check something in this package code or cut down a bug.

This can be found in branch master and also develop/8.2.0. I didn't checked other branches, because master is the reference and the develop/8.2.0 is the current WIP/next version to release branch.

To Reproduce

There's nothing to reproduce, but to double-check by navigating to:

Expected behavior

The source code and package names are consistent and follow a common naming schema (NuGet package name == *.csproj name).

Screenshots

image

Desktop (please complete the following information):

GFlisch commented 5 months ago

Hi @HaGGi13 , indeed this is inconsistent.

I will fix it. But the idea is the following: There is an inconsistency introduced to differentiate the framework built at the time of .NET 4.x and .NET Core. I introduced the term standard because the new framework was able to be used by .NET 4.x and .NET Core 3.1.

Nowadays I am not pleased by project named standard and targeting only .NET 6/8.

But I think a day I will have to discuss to rename projects and packages to remove the standard and see how on nuget I can put the standard ones as "deprecated" and that we have to use the non standard ones.

HaGGi13 commented 5 months ago

Yes, I saw this and understood the idea behind, that's the reason why I mention this project in the issue only. As you see in the screenshot it's targeting .NET Standard, beside .NET 6 and 8, hence your naming convention is not applied. Other projects are fine and aligned with your convention, or rather I didn't noticed other inconsistency.

HaGGi13 commented 5 months ago

@GFlisch and I had a talk about and it was solved in the meantime.