(1)
There is a naming anomaly in CommonMessageLogger that violates the principle of least astonishment:
LogLevel.Information -level messages are added by methods Information/LogInformation: OK!
LogLevel.Warning -level messages are added by methods Warning/LogWarning: OK!
LogLevel.Error -level messages are added by methods Error/LogError: OK!
but:
LogLevel.Critical -level messages are added by methods Fatal/LogFatal: ASTONISHING!
This pull request adds the expected Critical/LogCritical methods for LogLevel.Critical-level messages, and declares the Fatal/LogFatal as obsolete. All references to the latter in Arc4u are changed appropriately.
(2)
There is no accessible method to log Loglevel.Trace-level messages. The System method uses this log level, but it's only for internal Arc4u use. However, it is legitimate for user core to log LogLevel-Trace-level messages.
This pull request adds the Trace/LogTrace methods for LogLevel-Trace-level messages, accessible in user code.
The System method still exists, but contains a structured property "Arc4u" with value "Internal" to be able to disambiguate those logs messages if needed.
(1) There is a naming anomaly in CommonMessageLogger that violates the principle of least astonishment:
LogLevel.Information-level messages are added by methodsInformation/LogInformation: OK!LogLevel.Warning-level messages are added by methodsWarning/LogWarning: OK!LogLevel.Error-level messages are added by methodsError/LogError: OK!but:
LogLevel.Critical-level messages are added by methodsFatal/LogFatal: ASTONISHING!This pull request adds the expected
Critical/LogCriticalmethods forLogLevel.Critical-level messages, and declares theFatal/LogFatalas obsolete. All references to the latter in Arc4u are changed appropriately.(2) There is no accessible method to log
Loglevel.Trace-level messages. TheSystemmethod uses this log level, but it's only for internal Arc4u use. However, it is legitimate for user core to logLogLevel-Trace-level messages.This pull request adds the
Trace/LogTracemethods forLogLevel-Trace-level messages, accessible in user code. TheSystemmethod still exists, but contains a structured property"Arc4u"with value"Internal"to be able to disambiguate those logs messages if needed.