added platform specific memory() function

GGiecold-zz / DBSCAN_multiplex

A fast and efficient implementation of DBSCAN clustering.

MIT License

52 stars 17 forks source link

added platform specific memory() function #4

Closed skelow closed 7 years ago

skelow commented 7 years ago

How's it look Gregory? This should robustly figure out which OS is used and call memory accordingly, we might want to test this on a linux platform beforehand, I only tested it on my MacOSX version. Thanks

skelow commented 7 years ago

Hey Gregory, here are some new changes. More readable with less booleans. Same principle with native code, what do you think?

skelow commented 7 years ago

Added the catch for unsupported platform. In spite of this memory function, would this software work on PC platform?

GGiecold-zz commented 7 years ago

In a Windows environment, there is no guarantee that the name of a tempfile.NamedTemporaryFile instance can be used a second time while that file is still open. DBSCAN_multiplex involves a call to load(f.name, ...) that might be problematic in this regard.

That said, please go ahead and test DBSCAN_multiplex on VMWare or a machine running on Windows.