search

GGist / ssdp-rs

Simple Service Discovery Protocol In Rust
Apache License 2.0
42 stars 13 forks source link

Remove explicit Reflect implementation #26

Closed ebarnard closed 8 years ago

ebarnard commented 8 years ago

Reflect is implemented automatically. lookup_host is unused.

All tests pass on nightly and 1.9.0.

GGist commented 8 years ago

Not sure why the travis build is failing, looks to be unrelated.

However, as you saw with the appveyor build, we are currently using lookup_host on Windows to get all local network interfaces. Ideally we would used some Windows specific API to get this information and bake that into the ifaces crate.

However, I would gladly accept the pull request for removing the explicit Reflect impl.

ebarnard commented 8 years ago

I didn't notice that.

It's been a while since I've worked on windows but I'll see if I can get ifaces to work.

On 28 Jun 2016, at 08:24, Andrew notifications@github.com wrote:

Not sure why the travis build is failing, looks to be unrelated.

However, as you saw with the appveyor build, we are currently using lookup_host on Windows to get all local network interfaces. Ideally we would used some Windows specific API to get this information and bake that into the ifaces crate.

However, I would gladly accept the pull request for removing the explicit Reflect impl.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

GGist commented 8 years ago

Thanks for the changes.

Cheers!