search

GIPSY-dev / WSC-Gen

The Planning Graph Algorithm Implementation
1 stars 1 forks source link

Datasets branch made into a SOAP WebService #5

Closed Mchapuis closed 6 years ago

Mchapuis commented 6 years ago

We made temporary fixes to be transform the Generator into a web service. Please review the WebService_README.txt file in /doc folder for details.

This version is still not working correctly because we are back to our original problem. When I did the wrapper for the Generator, I used the swing library and java.io.File to save files. I need to correct this because JAX-RPC is not using these.

The service class "ca.concordia.cse.gipsy.ws.soap.Generator" does not comply to one or more requirements of the JAX-RPC 1.1 specification, and may not deploy or function correctly. The method "getOutputFolder" on the service class "ca.concordia.cse.gipsy.ws.soap.Generator" uses a data type, "java.io.File", that is not supported by the JAX-RPC specification. Instances of the type may not serialize or deserialize correctly. Loss of data or complete failure of the Web service may result. The method "containsFile" on the service class "ca.concordia.cse.gipsy.ws.soap.Generator" uses a data type, "java.io.File", that is not supported by the JAX-RPC specification. Instances of the type may not serialize or deserialize correctly. Loss of data or complete failure of the Web

But the project is building correctly now.

smokhov commented 6 years ago
smokhov commented 6 years ago

@jashanj0tsingh -- please review PM1.3 portion of this PR -- comment on its description, diffs, etc. whether it adequately matches the spec; then test quickly a copy of it locally.

smokhov commented 6 years ago
smokhov commented 6 years ago
Mchapuis commented 6 years ago

about d) Yes, when @mariegobran showed me the error I understood that I had made a mistake. I need to modify the wrapper like you described as soon as I can for the rest of the PM's to work correctly.

smokhov commented 6 years ago

@jashanj0tsingh -- the project report and class diagram issues belong to the bb issues for now; no need for that part here in this repo. README, OpenESB, etc. are valid.

Mchapuis commented 6 years ago

@jashanj0tsingh We are facing similar problems when opening/importing the project in OpenESB. We still don't know the correct way to do it.

smokhov commented 6 years ago

@Mchapuis @jdesorm1 @mariegobran -- folks, this PR is about PM1 and its associated issues. For now please stop pushing PM2 stuff to your Datatsets branch as anything you push there in your fork ends up in this PR until it's merged. Please separate PM2 stuff into PM2 branch (off the tip of Datasets) and keep it there until it's time to submit. You can sync PM2 branch from Datasets from time to time but don't "litter" this PR else's it's going to delay further the review. Please move (git allows you to) the commits like a63bd6d, 433b2b3 to the PM2 branch in your fork.

Mchapuis commented 6 years ago

The push @mariegobran and me did yesterday was for PM1, but we should have referenced PM1 for clarity, we will do this next time. @jdesorm1 fixed his push so now Datasets should be ok and contain only PM1 work.

Mchapuis commented 6 years ago

I don't know what happened with the Datasets branch but it seems like it has been rebase or something else happened. I am trying to fix this, we might have to revert and start over if I can't find the problem.

Mchapuis commented 6 years ago

I need to create a new pull request with the correct changes. This branch should be deleted.

smokhov commented 6 years ago

@Mchapuis -- I recommend against deleting the Datasets branch in your fork since we still have upstream. Instead, once your PR #7 is merged, rebase (force) your Datasets from us. And for the future really use branches like PM2 off the current tip of whatever branch you are working off from.