GIRA / PhysicalBits

A web-based programming environment for educational robotics that supports live coding and autonomy using a hybrid blocks/text programming language.
https://gira.github.io/PhysicalBits/
MIT License
18 stars 5 forks source link

Timer block behaves odd when changing locale #17

Closed kristiank closed 4 years ago

kristiank commented 4 years ago

Now for example when I have chosen Estonian language and created a timer block and set it ticking 2 times per second, and then change language to English, then the value changes to tick 1000 times per second. If I further change to Spanish locale, then the code generation breaks because the timer block is set to tick 1000 per 1000 (i.e. not per second). Changing the locale to Estonian or English sets the timer back to tick 1000 per second and code generation succeeds. Very strange. Maybe I have some time to investigate this tomorrow.

Edit: this happens atleast on the all-caps-mode branch and with Firefox.

kristiank commented 4 years ago

Fixed by @RichoM in 1855c2a950c3dfb920458802fddb0ac27a8f4d9f