GIScience / ohsome-qgis-plugin

ohsome Qgis plugin
MIT License
6 stars 1 forks source link

UI Improvements #60

Closed koebi closed 8 months ago

koebi commented 9 months ago

After reviewing the UI in the qgis-like-output branch, the following possible improvements came up:

merydian commented 9 months ago

keep geometry less applies the dict.pop() method on the dictionary created from the response geojson, with "Feature" as an argument. This, when checked, results in the output of an additional table without geometry, containing the same data as the usual output file.

merydian commented 9 months ago

The branch qgis-like-input solves: The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped by taking input by selecting a layer, as in any other QGis tool. This dismisses the existing Centroids input option.

What is the preferred option?

koebi commented 9 months ago

keep geometry less applies the dict.pop() method on the dictionary created from the response geojson, with "Feature" as an argument. This, when checked, results in the output of an additional table without geometry, containing the same data as the usual output file.

Then this could maybe be called "also save only data" or something similar. I think the space for a more "lengthy" name is there, and there should be the possiblity to add a "comment" that only gets shown on mouseover.

koebi commented 9 months ago

The branch qgis-like-input solves: The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped by taking input by selecting a layer, as in any other QGis tool. This dismisses the existing Centroids input option.

What is the preferred option?

Is it possible to keep the Centroids-option and have all other layer inputs as QGIS usually does? If not, I'd like @mcauer and/or @joker234 to comment on this, since they have a better intuition on what will be more useful to our users.

merydian commented 9 months ago

Regarding: if a layer contains a lot of points, the log gets rather long. could we add truncation to the geometry part in the log?: I assume we are talking about the View'->'Panels'->'Log Messages' log? From the documentation it seems that this was intentionally kept to full length for debugging reasons. Should we add truncation anyways?

merydian commented 9 months ago

The branch qgis-like-input solves: The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped by taking input by selecting a layer, as in any other QGis tool. This dismisses the existing Centroids input option. What is the preferred option?

Is it possible to keep the Centroids-option and have all other layer inputs as QGIS usually does? If not, I'd like @mcauer and/or @joker234 to comment on this, since they have a better intuition on what will be more useful to our users.

I suppose with a days worth of work it could be done.

koebi commented 9 months ago

Regarding: if a layer contains a lot of points, the log gets rather long. could we add truncation to the geometry part in the log?: I assume we are talking about the View'->'Panels'->'Log Messages' log? From the documentation it seems that this was intentionally kept to full length for debugging reasons. Should we add truncation anyways?

Yes, exactly. If possible, it would be good if only the geometry could be truncated, such that you still have the original request, but your geometry looks like:

points: point1, point2, point3, …

merydian commented 9 months ago

Regarding: May metadata requests when provider changes, this is due to the temporal index being adapted. Isn't this a necessary step?

koebi commented 9 months ago

In general, yes. It is something that shouldn't change too often, and that could be cached and updated once/day? It might be a bit of premature optimization though, I'm also fine with keeping it how it is currently and adding an issue (to then tackle later on, hopefully).

mcauer commented 9 months ago

The branch qgis-like-input solves: The option to add multiple point or polygon layers seems a bit unnecessary and can be dropped by taking input by selecting a layer, as in any other QGis tool. This dismisses the existing Centroids input option. What is the preferred option?

Is it possible to keep the Centroids-option and have all other layer inputs as QGIS usually does? If not, I'd like @mcauer and/or @joker234 to comment on this, since they have a better intuition on what will be more useful to our users.

I suppose with a days worth of work it could be done.

I would say it is worth to put some effort and keep interactive centroid option in addition to choose some layer input

koebi commented 8 months ago

fixed in #58