GIScience / openrouteservice-app-legacy

OpenRouteService is an online route planning application that is based on open source software, open data and open standards.
MIT License
55 stars 36 forks source link

Roundtrip Bugreports #328

Closed TimMcCauley closed 7 years ago

HendrikLeuschner commented 8 years ago

RT1

Adding to, then removing a waypoint (via) from an existing roundtrip route causes end-roundtrip wp to not be dragged

Rungee commented 8 years ago

RT2

I've noticed an incorrect behavior when the roundtrip option is activated and one adds either start or end waypoint. In the current implementation, the end point is automatically added even a user specified only one waypoint.

ors_roundtrip_issue1

Rungee commented 8 years ago

RT3

Another issue: Roundtrip flag is not stored in permalink.

Rungee commented 8 years ago

RT4

One more issue :)

  1. Create a round trip using the following link http://openls.geog.uni-heidelberg.de/openrouteservice-3.0/?pos=9.079685211181642,49.397987771900276&zoom=16&layer=00B0000&routeOpt=Car&wp=9.076552391052248,49.399705396513454,9.069364070892336,49.3990211467527,9.073462486267092,49.3979039837971,9.076552391052248,49.399705396513454&lang=en&routeLang=en&distUnit=m&surface=cobblestone:flattened&incline=6&slopedCurb=0.06&routeWeight=Fastest&trackType=grade2
  2. Remove a waypoint which has an address of Querstraße 7 69437 Neckargerach, Regierungsbezirk Karlsruhe, Baden-Württemberg, Germany
  3. The client yields no results any longer, since the server always responds with an error
<?xml version="1.0" encoding="UTF-8"?>
<xls:XLS xmlns:xls="http://www.opengis.net/xls" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 version="1.1" xsi:schemaLocation="http://www.opengis.net/xlsXLS.xsd">
  <xls:ResponseHeader xsi:type="xls:ResponseHeaderType" sessionID="Error"/>
  <xls:_Body xsi:type="xls:ResponseType" requestID="" version="1.1">
    <xls:ErrorList>
      <xls:Error errorCode="OtherXml" severity="Error" locationPath="value:" message="XmlBeans validation
 error: Invalid double value: undefined"/>
    </xls:ErrorList>
  </xls:_Body>
</xls:XLS>

If we take a look at the request, then we find out that it is corrupted. See the last point in WayPointList (undefined undefined/gml:pos)

<xls:WayPointList>
                    <xls:StartPoint>
                        <xls:Position>
                            <gml:Point xmlns:gml="http://www.opengis.net/gml">
                                <gml:pos srsName="EPSG:4326">9.076552391052248 49.399705396513454</gml:pos>
                            </gml:Point>
                        </xls:Position>
                    </xls:StartPoint>
                    <xls:ViaPoint>
                        <xls:Position>
                            <gml:Point xmlns:gml="http://www.opengis.net/gml">
                                <gml:pos srsName="EPSG:4326">undefined undefined</gml:pos>
                            </gml:Point>
                        </xls:Position>
                    </xls:ViaPoint>
                    <xls:ViaPoint>
                        <xls:Position>
                            <gml:Point xmlns:gml="http://www.opengis.net/gml">
                                <gml:pos srsName="EPSG:4326">9.076831340789797 49.39980314570102</gml:pos>
                            </gml:Point>
                        </xls:Position>
                    </xls:ViaPoint>
                    <xls:EndPoint>
                        <xls:Position>
                            <gml:Point xmlns:gml="http://www.opengis.net/gml">
                                <gml:pos srsName="EPSG:4326">undefined undefined</gml:pos>
                            </gml:Point>
                        </xls:Position>
                    </xls:EndPoint>
                </xls:WayPointList>
HendrikLeuschner commented 8 years ago

Hey Max, thank you for all the comments. Concerning #RT2: This is exactly the expected behavior. A roundtrip specification means that start and end point are always the same, thus either is added as soon as start or end point is added, respectively. Do you find this counterintuitive? This is the very heart of the roundtrip feature: On the map you have a single waypoint in blue which you can drag. Dragging it automatically updates (should update if there are no bugs...) both blue waypoints in the waypoint list on the left. Changing one waypoint automatically always changes the other one as well. I (as a user) would find it more confusing if I'd enable roundtrip and then have only a start point in my waypoints list.

VG

HendrikLeuschner commented 8 years ago

RT1, #RT2, #RT4 solved.

RT5: Sometimes wrong marker is dragged ondrag

RT5 solved