GIScience / openrouteservice-js

:pushpin: The JavaScript API to consume openrouteservice(s) painlessly!
https://openrouteservice.org
Apache License 2.0
191 stars 35 forks source link

replace bluebird promises with async/await & superagent with native fetch #63

Closed EmmaHegarty closed 1 year ago

EmmaHegarty commented 1 year ago

removes dependency on bluebird and superagent, solves #61 and #64

codecov-commenter commented 1 year ago

Codecov Report

Merging #63 (76c4eea) into main (e8bf723) will increase coverage by 2.84%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   94.24%   97.09%   +2.84%     
==========================================
  Files          16       16              
  Lines         365      344      -21     
  Branches       67       58       -9     
==========================================
- Hits          344      334      -10     
+ Misses         19        9      -10     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
src/OrsDirections.js 100.00% <ø> (ø)
src/OrsIsochrones.js 100.00% <ø> (ø)
dev_app/components/helloWorld.js 88.88% <100.00%> (-2.03%) :arrow_down:
src/OrsBase.js 100.00% <100.00%> (+3.84%) :arrow_up:
src/OrsElevation.js 100.00% <100.00%> (ø)
src/OrsGeocode.js 100.00% <100.00%> (+7.82%) :arrow_up:
src/OrsOptimization.js 100.00% <100.00%> (ø)
src/OrsPois.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication