GIScience / openrouteservice-js

:pushpin: The JavaScript API to consume openrouteservice(s) painlessly!
https://openrouteservice.org
Apache License 2.0
191 stars 35 forks source link

fix: gpx response not returned correctly #75

Closed TheGreatRefrigerator closed 11 months ago

TheGreatRefrigerator commented 11 months ago

the text response from the gpx endpoint was also retrieved through the .json function of the Response object which threw an error as it was not possible to parse the gpx to json.

For gpx it now uses the .text function instead and just returns the gpx result as a string.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov-commenter commented 11 months ago

Codecov Report

Merging #75 (c9a3865) into main (2504198) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          15       15           
  Lines         331      331           
  Branches       57       57           
=======================================
  Hits          328      328           
  Misses          3        3           
Files Changed Coverage Δ
src/OrsBase.js 100.00% <100.00%> (ø)