GIScience / openrouteservice-r

:globe_with_meridians: query openrouteservice API from R
https://giscience.github.io/openrouteservice-r/
Apache License 2.0
98 stars 23 forks source link

Switch secret storage from keyring to .Renviron #34

Open aoles opened 6 years ago

aoles commented 6 years ago

Abandon the notorious keyring package which is causing trouble under certain architectures and deployment environments such as shinyapps.io.

The idea is to store the key as plain environment variable, preferable in .Renviron. In order to ease-up the set-up procedure and to retain previous functionality introduce an intelligent way of updating .Renviron through a call to ors_api_key(<YOUR_API_KEY>). See ?Startup for R startup details.

To remain CRAN compliant, ask for user permission before updating .Renviron (see e.g. rsam).

aoles commented 6 years ago

Builds are failing on Travis CI because libsodium-dev system package on which keyring now indirectly depends is not available on Ubuntu 14.04.