GIScience / openrouteservice

🌍 The open source route planner api with plenty of features.
https://openrouteservice.org
GNU General Public License v3.0
1.41k stars 388 forks source link

Invalid srtm_38_03.zip when restarting tomcat multiple times #1018

Open knowname opened 3 years ago

knowname commented 3 years ago

Here's what I did

During my Ansible setup for ORS I accidentally restarted tomcat 2 times in a row with little time in between. My profile included car with elevation.


Here's what I got

Corrupt SRTM ZIP-File


Here's what I was expecting

Validate the elevation data before use and try to update it if necessary.


Here's what I think could be improved

I am not sure if the part where this check must be done is here or in graphhopper. anyway its good to know.

knowname commented 3 years ago

The workaround is deleting the elevation data (as suggested here https://github.com/GIScience/openrouteservice/issues/576) and restarting tomcat. This will trigger a fresh download.

takb commented 3 years ago

Elevation data processing is in graphhopper code, this is something we could think about looking into at some point in the future (as currently we don't have the manpower), thx for the report!