GIScience / openrouteservice

🌍 The open source route planner api with plenty of features.
https://openrouteservice.org
GNU General Public License v3.0
1.33k stars 379 forks source link

Isochrones with Uber traffic data #1500

Open redfrexx opened 11 months ago

redfrexx commented 11 months ago

Is there an existing issue for this?

Feature/Enhancement Proposal

The current prototypical Uber traffic data integration in the implement_uber_traffic branch only works for routing, but not for isochrones. Adding support for isochrones would enable us to do several high impact analyses and visuals (isochrones across day) which we could show at upcoming conferences. For that to work, it would be necessary to have it until mid August. Not necessary to have it in master.

Additional context

No response

Possible Implementation

No response

Forum Topic Link

No response

rabidllama commented 11 months ago

The problem isn't with the isochrones themselves, but a missing timezone decleration. If you set that in the AbstractTrafficGraphStorage (currently isn't initialised) then you can get isochrones. However, that is then hardcoding it to a single time zone which isn't the proper solution

MichaelsJP commented 11 months ago

You're right. We were just serving Germany so far. If you're not hardcoding it, you deal with this monstrosity :smile: --> image

MichaelsJP commented 11 months ago

We had a half working solution before, where a library was used to translate coordinates into Time Zones. But it was utterly slow and not actively maintained. We had to remove it. So far, we haven't found a suitable solution. Maybe it's worth just providing a parameter to select the time zone manually for now. It should be sufficient for the smaller Uber traffic data use cases. What do you think?

MichaelsJP commented 11 months ago

It could be worth looking into using https://github.com/evansiroky/timezone-boundary-builder. Kind of the successor to http://efele.net/maps/tz/world/

MichaelsJP commented 11 months ago

Just found this issue: https://github.com/GIScience/openrouteservice/issues/1317