GIScience / openrouteservice

🌍 The open source route planner api with plenty of features.
https://openrouteservice.org
GNU General Public License v3.0
1.33k stars 379 forks source link

Missing way in preprocessed test graph #1761

Open aoles opened 3 months ago

aoles commented 3 months ago

Problem description

ORS API tests run against HD test graph filtered through either ors-preprocessor or osm-transform fail with the following.

[ERROR] Failures: 
[ERROR]   ResultTest.testWheelchairKerbRestriction:2102 1 expectation failed.
JSON path routes[0].summary.distance doesn't match.
Expected: is <74.1F>
  Actual: <105.9F>

[ERROR]   ResultTest.testWheelchairWidthRestriction:2021 1 expectation failed.
JSON path routes[0].summary.distance doesn't match.
Expected: is <158.7F>
  Actual: <158.8F>

Proposed solution

Check which OSM tags are relevant for wheelchair routing, as probably some of them are discarded by the preprocessor.

aoles commented 3 months ago

The problem seems to be caused by a footpath=crossing-type way missing from the processed file. As this is not about missing wheelchair-specific tags but an entire way not being present the issue is not limited to the wheelchair profile only but affects any other profiles allowed to use the missing way, such as foot-walking, for example.

original heidelberg.osm.gz

Screenshot 2024-03-26 at 22 49 56

processed heidelberg.ors.pbf

Screenshot 2024-03-26 at 22 51 48
aoles commented 3 months ago

It seems that the way is missing because for some unclear reason its ID is set to a negative value (-3556006) and only ways with positive IDs are being copied over in the preprocessing.