Support bicycle=destination for bike profiles

GIScience / openrouteservice

🌍 The open source route planner api with plenty of features.

https://openrouteservice.org

GNU General Public License v3.0

1.33k stars 379 forks source link

Support bicycle=destination for bike profiles #1782

Closed waldyrious closed 1 month ago

waldyrious commented 2 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Feature/Enhancement Proposal

The bike routing should allow routing through paths marked with "bicycle=destination". For example, this route should follow this sequence of ways: 1262007841, 1262007844, 1262007834, 1262007838, 1262007843; but instead it goes around the square:

Additional context

No response

Possible Implementation

No response

Forum Topic Link

No response

aoles commented 1 month ago

Hi @waldyrious,

First of all thank you for raising the issue and for opening a corresponding PR with a fix.

While I understand your concerns, I don't believe this is actually a valid issue. This is so because routing on OSM ways tagged with bicycle=destination is not disabled in general. However, transit traffic on ways tagged with access destination is forbidden and it is allowed to use the way only to reach a destination that can not be reached otherwise, see OSM wiki. This is also the reason why the way is not used in your example. The described behaviour becomes evident once you choose a via point on the way in question.

Cheers, Andrzej

waldyrious commented 1 month ago

Oh, I see! Thanks for the explanation. I suppose the path is mistagged, then, as it is not forbidden to bike there. I'll fix the map. Cheers!

aoles commented 1 month ago

Thanks! Not sure either where the tagging comes from. I had a quick look via StreetView on the neighborhood in question but couldn't spot any signs limiting access to the square. As you said, it seems to be perfectly fine to take the shortcut.