GIScience / ors-map-client

Openrouteservice API web SPA client using VueJS, Vuetify and Vue2Leaflet
http://maps.openrouteservice.org
Apache License 2.0
111 stars 33 forks source link

Improve english texts #301

Open koebi opened 1 year ago

koebi commented 1 year ago

When reviewing a foreign language PR, I noticed that the english texts lack in some places: https://github.com/GIScience/ors-map-client/blob/1ec61b7e7ec5e9b4d91715c3fe52b128b8ad425c/src/fragments/map-view/i18n/map-view.i18n.en-us.js#L46-L48

They are probably the basis for any translation, so I suggest the following improvements:

I'm open for discussions whether "Define" or "Draw" is more appropriate here.

TheGreatRefrigerator commented 1 year ago

👍🏻 would vote for "Draw" instead of "Define"

koebi commented 1 year ago

other places include https://github.com/GIScience/ors-map-client/blob/1ec61b7e7ec5e9b4d91715c3fe52b128b8ad425c/src/fragments/forms/map-form/components/place-and-directions/i18n/places-and-directions.i18n.en-us.js#L8

koebi commented 1 year ago

Also note, that the translation file is named differently from the component.

koebi commented 1 year ago
couldNotDetermineYourLocation: 'Your location could not be determined. Make sure granted the required permissions',
koebi commented 1 year ago
noPlaceFound: 'No place found with the imputed content',
koebi commented 1 year ago
unknownSearchPlaceError: 'Unknown search place error'

better: location?