GIScience / ors-map-client

Openrouteservice API web SPA client using VueJS, Vuetify and Vue2Leaflet
http://maps.openrouteservice.org
Apache License 2.0
106 stars 32 forks source link

test/312 migrate integration tests #325

Closed TheGreatRefrigerator closed 1 year ago

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
27.3% 27.3% Duplication

TheGreatRefrigerator commented 1 year ago

test were failing due to one component test importing app.js instead of App.vue which was confusingly still working locally... The other part was the API key not being passed properly (env variable reading) which was missing in the cypress webpack config. This will need adjustment for the switch to using .env file(s).

Regarding Sonar cloud:

In my opinion they can be ignored.

If you agree this is ready for Review and Merging from my side