GIScience / ors-map-client

Openrouteservice API web SPA client using VueJS, Vuetify and Vue2Leaflet
http://maps.openrouteservice.org
Apache License 2.0
106 stars 32 forks source link

refactor: cleanup various problems #389

Closed TheGreatRefrigerator closed 1 year ago

TheGreatRefrigerator commented 1 year ago

Fixes various issues reported by WebStorm to make error reporting more meaningful.

Typos in translation strings and parts with important and complex functionality were left out. (e.g. overlayer.. props like overlayerTileProviders used in config and hooks)

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

TheGreatRefrigerator commented 1 year ago

The code smell Prefer using an optional chain expression instead, as it's more concise and easier to read. is a decent catch, but as it's not "new" code but adjusted, i would ignore that here and change to optional chain expressions repo wide some other time. The Todo and the duplications were only adjusted (typos or similar) as well, not introduced.