search

GIScience / orstools-qgis-plugin

Plugin for QGIS with a set of tools to use openrouteservice API´s, based on openstreetmap
https://plugins.qgis.org/plugins/ORStools/
MIT License
91 stars 31 forks source link

Cannot generate route from line layer #123

Closed rabidllama closed 3 years ago

rabidllama commented 3 years ago

Here's what I did

Request a route using a line layer as source

Here's what I got

Error that the method is not valid: Network error #405: Error transferring https://api.openrouteservice.org/v2/directions/driving-car/geojson?coordinates=16.472234,48.17582%7C16.46278,48.18235&elevation=True&format=geojson&geometry=true&geometry_format=geojson&id=None&instructions=false&preference=fastest&profile=driving-car - server replied: Method Not Allowed

Here's what I was expecting

That the route is generated. The issue is because the system is sending the parameters in a GET request rather that a POST request

Here's what I think could be improved

I believe the culprit is line 231 in the proc/directions_lines_proc.py as it passes the parameters differently to the other directions processes. Changing that to match the others I think should force the POST request https://github.com/GIScience/orstools-qgis-plugin/blob/3cc6d3badb10740bfda6ec6ca07e748885349fdb/ORStools/proc/directions_lines_proc.py#L231 https://github.com/GIScience/orstools-qgis-plugin/blob/3cc6d3badb10740bfda6ec6ca07e748885349fdb/ORStools/proc/directions_points_layer_proc.py#L250