GIScience / orstools-qgis-plugin

Plugin for QGIS with a set of tools to use openrouteservice API´s, based on openstreetmap
https://plugins.qgis.org/plugins/ORStools/
MIT License
91 stars 31 forks source link

Add option to display snapped point(s) from isochrone request in separate layer #137

Closed koebi closed 2 years ago

koebi commented 3 years ago

Here's what I think could be improved

Currently, when requesting isochrones e.g. via Batch Jobs -> Isochrones from Point, if a user chooses a point by just clicking on the map, they have no way of knowing what the actual center of the calculated isochrones is short of manually looking it up in the ORS Tools-tab of the log messages panel.

Even then, that only states the requested location, not the actual center. It would be good to have an option to generate a new layer from the snapped center points.

koebi commented 2 years ago

Adding a new layer would mean cluttering the processing algorithm interface even more. I'd propose adding two attributes to the polygons in the polygon layer, namely center_lat and center_lon. That way, people interested in this could extract the infos from the polygon and the info would be related directly to the polygon, not in a different, non-connected layer.

TheGreatRefrigerator commented 2 years ago

I think the output should be instantly visually available, as this is the strong point of QGIS after all compared to more programmatic approaches. This could rather be an additional setting in the processing window to let the user choose if he want's the center displayed. All geojsons containing different types need to be imported as separate layers in qgis, so users should be familiar with the concept of having separate layers for connected data. wdyt @koebi?

koebi commented 2 years ago

…why not both? ;)

koebi commented 2 years ago

Let me expand on that:

I think that adding two attributes is a good idea and rather easy, and should be done anyways. My main reasoning not to add a layer, as stated, is to keep the proc interface as clean as possible.

If this is something we're aiming for, there's two things I can think of:

TheGreatRefrigerator commented 2 years ago

Ah i was not aware of the "Create Points layer from table" thing. If it's rather simple to add the center using this processing i guess we could leave the extra layer. But ther should be a pointer to that in the side documentation