GIScience / orstools-qgis-plugin

Plugin for QGIS with a set of tools to use openrouteservice API´s, based on openstreetmap
https://plugins.qgis.org/plugins/ORStools/
MIT License
91 stars 31 forks source link

`<str>.removesuffix()` only available in Python3.9 #215

Closed koebi closed 5 months ago

koebi commented 5 months ago

This comes from https://ask.openrouteservice.org/t/how-to-fix-this-provider-error-problem/5649/2

<str>.removesuffix() and <str>.removeprefix() are only available in Python 3.9.

I don't know which QGIS version this corresponds to - we should find that out and decide whether we want to refactor until QGIS broadly supports 3.9 or whether we keep and set a higher min version.

koebi commented 5 months ago

What I found out is that QGIS 3.18 bumped to Python 3.6 and QGIS 3.20 bumped to Python 3.7 and that's where we are now.

merydian commented 5 months ago

If the backwards compatibility is only dependent on this line why not change it to support older versions? Doesn't seem like a lot of work to me. Is there anything else problematic with older versions?

If this only allows the Plugin to run with Python 3.9 we should probably fix this quickly, right?