search

GIScience / orstools-qgis-plugin

Plugin for QGIS with a set of tools to use openrouteservice API´s, based on openstreetmap
https://plugins.qgis.org/plugins/ORStools/
MIT License
91 stars 31 forks source link

CSV weightings do not work for routes using two point layers #260

Closed rabidllama closed 1 month ago

rabidllama commented 1 month ago

Here's what I did

Used two point layers to generate routes whilst setting the csv factor and csv column parameters

Here's what I got

Error messages for each route trying to be generated:

Route from 1 to 1 caused a GenericServerError:
500 ({"error":{"message":"Value cannot be null. Use remove instead."},"info":{"engine":{"version":"6.8.0","build_date":"2023-08-14T08:18:41Z"},"timestamp":1716553132640}})

Here's what I was expecting

Generating routes as is the case for using a single layer for points, or not specifying csv parameters

Here's what I think could be improved

It looks like there is a missing parameter in the code for setting the csv column when using the multiple point layers (https://github.com/GIScience/orstools-qgis-plugin/blob/2f925e7fab6816d544d534be879cb04edd5fb247/ORStools/proc/directions_points_layers_proc.py#L161 vs https://github.com/GIScience/orstools-qgis-plugin/blob/2f925e7fab6816d544d534be879cb04edd5fb247/ORStools/proc/directions_points_layer_proc.py#L153)