search

GIScience / orstools-qgis-plugin

Plugin for QGIS with a set of tools to use openrouteservice API´s, based on openstreetmap
https://plugins.qgis.org/plugins/ORStools/
MIT License
95 stars 31 forks source link

intervals are not part of the attributes list #5

Closed riccardoklinger closed 7 years ago

riccardoklinger commented 7 years ago

Hi Nils,

first: great job! Unfortunately your isochrone analysis does not reflect intervals in the polygon layer. I would assume to see a polygon for each intervall. At the moment it is just one single polygon. grafik

nilsnolde commented 7 years ago

Ah damn, I actually fixed that! It works if you leave the default isochrone and interval though;) It´s a tiny bug in the change textbox event.

I´ll fix and revert.

Thanks for the quick reporting mate!

nilsnolde commented 7 years ago

Sorry, can´t reproduce.. To be sure I downloaded the version directly from the Plugin directory, it´s fine on my side: image

You´re sure you´re not using a deprecated version from GitHub? It´s only up-to-date in the trunk, not in the branch.

Can you plz look into the 'osm_tools_access.py': on line 83, it should say

def valueChanged(self): self.iso_max = self.dlg.iso_max.value() * 60 self.iso_int = self.dlg.iso_int.value() * 60

nilsnolde commented 7 years ago

Sorry, it should say:

    def valueChanged(self):
        self.iso_max = self.dlg.iso_max.value() * 60
        self.iso_int = self.dlg.iso_int.value() * 60
nilsnolde commented 7 years ago

Closing this, assuming it was a random error.