GIScience / orstools-qgis-plugin

Plugin for QGIS with a set of tools to use openrouteservice API´s, based on openstreetmap
https://plugins.qgis.org/plugins/ORStools/
MIT License
92 stars 31 forks source link

Isochrone measurement to allow the use of non-integer #53

Closed FlytPlan closed 5 years ago

FlytPlan commented 6 years ago

When selecting the Isochrone unit (time or distance), I’ve tried to select distance and use 0.4km to reflect a 400m walk catchment but the plugin freezes - I understand that this is because it requires integer values (i.e. at least 1 minute or 1km). For example it would be great to be able to use 0.4km to reflect a 400m walk distance. Thanks

yonnov commented 6 years ago

This worked for me (from Nils advice),

you can try to get around this in your local plugin installation, by replacing these lines in isochrone.py:

line 55:

self.factor = 60 if self.dimension == 'time' else 1000

to

self.factor = 60 if self.dimension == 'time' else 1

I then entered a value in meters (e.g. 400)

FlytPlan commented 6 years ago

Thanks for that Nils – it all works fine now.

Cheers

Matt

Matthew Root Flyt Pty Ltd 0403 677 970

From: yonnov notifications@github.com Sent: Thursday, 19 April 2018 6:55 PM To: nilsnolde/OSMtools OSMtools@noreply.github.com Cc: Matthew Root m.root@flyt.com.au; Author author@noreply.github.com Subject: Re: [nilsnolde/OSMtools] Isochrone measurement to allow the use of non-integer (#53)

This worked for me (from Nils advice),

you can try to get around this in your local plugin installation, by replacing these lines in isochrone.py:

line 55:

self.factor = 60 if self.dimension == 'time' else 1000

to

self.factor = 60 if self.dimension == 'time' else 1

I then entered a value in meters (e.g. 400)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/nilsnolde/OSMtools/issues/53#issuecomment-382693282, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkqqyQXbkCtXDBWRuzXOrKrK9vlBnodZks5tqGzngaJpZM4TXiH5.

nilsnolde commented 5 years ago

implemented in master.. now it's in meter instead of km