search

GIScience / oshdb

OpenStreetMap History Data Analysis Framework
https://ohsome.org
GNU Lesser General Public License v3.0
110 stars 18 forks source link

Endless loading in OSHRelation.getModificationTimestamps() #8

Closed FabiKo117 closed 6 years ago

FabiKo117 commented 6 years ago

When sending a simple request over the ohsome-API about bicycle routes for a small bbox in Rheinland-Pfalz (Germany), the code seems to be somehow stuck (or needs far too much time) within the OSHRelation.getModificationTimestamps() method. The reason seems to be that the relation https://www.openstreetmap.org/relation/88376#map=9/49.9658/7.3759 is quite big and has lots of versions and members with loads of different timestamps.

This is the request URI: /elements/count?time=2012-06-15&showMetadata=true&keys=route&values=bicycle&bboxes=7.6563,49.4635,7.7727,49.513&types=relation

tyrasd commented 6 years ago

It was not actually a bug. Just a part where the implementation was especially slow in some cases. With #10 this should be fixed.

tyrasd commented 6 years ago

PS: we found a related issue (using similar queries as the one above), where the internal buffering of the celliterator causes excessive memory usage, which is addressed in #20.