abukowski21 commented 1 week ago

[BUG] Squash two bugs: jday and Ovation,

I found some bugs in src/time_routines.f90 and in src/ModNewell.f90. Couple more things fixed along the way...

Changes to GITM outputs

Uhhh, things might change if the indices were using the wrong jday calculations. HPI was, I think....

Otherwise, things won't be different.

Character lengths in src/ModNewell.f90. Reference to Issue #14, but pushing this through since it's important.
File names when calling stop_gitm look funny sunce they're all 600 characters now. Put a trim() before some of them
Better test coverage. Newell aurora weren't actually called (now they are). And there's a test of only statistical models too (test.05).

NOTE: I think this PR is going to fail formatting checks. Let's call this a test.

abukowski21 commented 1 week ago

Second commit passed formatting test, so the code is formatted correctly & the test works.

Dan Brandt is trying to run GITM with OVATION so I'm sending the PR in "after hours".

aaronjridley commented 1 week ago

it looks like if you approve when looking at a specific file, it approves the entire pull request. Hmmm, something to keep in mind!