search

GITMCode / GITM

The Global Ionosphere/Thermosphere Model
Apache License 2.0
9 stars 9 forks source link

code works with f107 is not current #6

Closed aaronjridley closed 1 month ago

aaronjridley commented 5 months ago

When you run GITM for current time periods and the F107 is not up-to-date, the code shows no warnings or anything.

The code should either stop or throw lots of warnings.

abukowski21 commented 1 month ago

This issue in GITM is fixed, however it seems to have made more errors when GITM is run as an SWMF component.

I can send in more details, but the gist is:

Code will not compile (check_all_inputs is in GITM's util folder)

I was looking at it for a while & couldn't get it fixed...

To reproduce:

git clone [--depth 1] git@github.com:SWMFSoftware/SWMF.git
cd SWMF
./Config.pl -install [-O0] -v=UA/GITM 
make test3

tail -n 100 run_test/runlog

NOTE: GITM/srcSphereAB and srcGlow won't compile with make -j test3. I git it fixed (briefly) in the swmf_bigfixes branch, but then I tried with a fresh install and it broke, haha. So parallel compiling is still broken.

aaronjridley commented 1 month ago

Well, crap. I guess this means that we need to add the SWMF test to the pull requests????

And solve this problem. Ugh. I can help with this if you want to meet to discuss.

On Mon, Sep 30, 2024 at 3:01 PM Aaron Bukowski @.***> wrote:

This issue in GITM is fixed, however it seems to have made more errors when GITM is run as an SWMF component.

I can send in more details, but the gist is:

Code will not compile (check_all_inputs is in GITM's util folder)

  • Moving that subroutine to (GITM/src/set_inputs.f90 or) SWMF/util/.../inidices_library.f90 gets it to compile. But then GITM can't read the IMF file
  • Swapping from read_MHDIMF_Indices_new -> read_MHDIMF_Indices (not new) in GITM/src/src_inputs.f90 does read, but then stops running with the time error
    • Increasing run time does not fix this, same issues with any start/stop times
    • imf file has entries every 1 minute, even runs for 1+ hour don't work

I was looking at it for a while & couldn't get it fixed...

To reproduce:

  • clone SWMF & cd into it
  • install with GITM
  • compile test3 and run (use -O0 for faster compilation - see fix below).

git clone [--depth 1] @.***:SWMFSoftware/SWMF.gitcd SWMF ./Config.pl -install [-O0] -v=UA/GITM make test3

tail -n 100 run_test/runlog

NOTE: GITM/srcSphereAB and srcGlow won't compile with make -j test3. I git it fixed (briefly) in the swmf_bigfixes branch, but then I tried with a fresh install and it broke, haha. So parallel compiling is still broken.

— Reply to this email directly, view it on GitHub https://github.com/GITMCode/GITM/issues/6#issuecomment-2383944024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOYHCQCILTKZFQNYXIJQYLZZGNWVAVCNFSM6AAAAABIRPFNJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTHE2DIMBSGQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Aaron Ridley, Professor University of Michigan 1416 Space Research Building Ann Arbor, MI 48109-2143 (734) 764-5727

abukowski21 commented 1 month ago

Fixed in pull request #22 , I think