search

GJordao / simple-auth

An authentication service that aims to be simple and customisable
MIT License
3 stars 3 forks source link

Create node.js-CI.yml #5

Closed MicroAnibal closed 3 years ago

MicroAnibal commented 3 years ago

Add initial github workflow to build and test. Based on node.js workflow.

For now limited builds and tests for master branch and PR's.

nneves commented 3 years ago

ping @MicroAnibal , after making your pipeline tests make sure you last test succeeds for the "Review" box to be green. This will avoid some confusions from the reviewer part.

nneves commented 3 years ago

Nevermind, checked the workflow code and pipeline jobs results, it's failling because the unit tests are failling :)

MicroAnibal commented 3 years ago

Thanks @nneves, good point, for now this will only add a base to run tests automatically. Next step: add more tests and fix current failing ones.

nneves commented 3 years ago

@MicroAnibal sometimes it's nice to have just a few basic tests to pass the pipeline, the Golden path test suite, the ones that are the most important... latter you keep adding the stable tests to the Golden path and run all in local development.

MicroAnibal commented 3 years ago

@nneves, added a dummy test and commented the failing test to be rewritten, golden path now working :) :rocket: Next, add more focused tests :+1:

nneves commented 3 years ago

@MicroAnibal Nice, all green now :)

MicroAnibal commented 3 years ago

Build now generates an artifact that is used for the matrix testing. Build only runs once.

MicroAnibal commented 3 years ago

Added windows-latest and macos-latest to test matrix.

MicroAnibal commented 3 years ago

Changes implemented. One more look @GJordao , @nneves. If all Ok, feel free to close :+1: