GLAMOS / dataflow

Code and tools for data exchange between GLAMOS and externals partners.
http://www.glamos.ch
Other
1 stars 3 forks source link

Including additional methods to retrieve glaciers from the database #24

Closed yweidmann closed 6 years ago

yweidmann commented 6 years ago

Additional methods to be implemented to retrieve Glacier objects from DataReaders.DatabaseReaders.GlacierReader.

Currently only getAllGlaciers() and getGlacierBySgi(pkSgi) are implemented. It would be helpful to have functions to retrieve Glacier objects by the geographical location. Possible methods:

What kind of other functions do we need?

jlandmann commented 6 years ago

Really cool idea! I think getting a subset of glacier by polygon would be cool to have, this would be especially useful to those that work with hydrological catchments or region-/canton-based analyses.

yweidmann commented 6 years ago

Oups. I overlooked the mention idea "glacier by polygon". Will see about an implementation with a polygon as WKT as parameter. Should be easy.

Regarding hydrology and administrative boundaries: I prefer an implementation without geometries. Retrieving glaciers based on such properties can be done using the attributes ans logical operations.

For the major river catchment super easy to implement would be:

jlandmann commented 6 years ago

This is really really a cool feature! It makes it possible not only to make region-based requests, but also catchment-based requests (given a catchment polygon, which is quite easy to generate)! Great work!