search

GLEIF-IT / reg-pilot-webapp

regulator pilot webapp using secure extension
Apache License 2.0
1 stars 2 forks source link

Spinning icon on SELECT CREDENTIAL button sometimes doesn't stop #107

Open edeykholt opened 3 weeks ago

edeykholt commented 3 weeks ago

Environment: Installed signify-browser-extension from today’s build v0.0.1-5d47ae0.zip https://reg-pilot-webapp-test.rootsid.cloud/

Repro steps and results

  1. Configure extension, using the passcode Ap31Xt-FGcNXpkxmBYMQn
  2. SELECT CREDENTIAL. The spinning Icon appears on the button.
  3. Click on action icon
  4. Enter passcode, then Connect
  5. Select the ECR credential in the popup
  6. Then the same in the page popup
  7. Select “X” on the page popup.

Expected: the spinner should stop (or eventually time out).
I’d also like to see a /signify/reply or other response interface defined, in case an extension builder wants to support an UX where the user intentionally doesn’t want to approve a sign-in request.

  1. Click on the Action Icon
  2. Select Disconnect
  3. Click on the Page, which dismisses the Action Popup.

Expected: the spinner should also stop (or eventually time out).

  1. Click again on SELECT CREDENTIAL. Seems to work as normal.

**Actual: Also, the SELECT CREDENTIAL button appears to be always enabled.

Expected: It should be disabled when it is waiting for a reply from the extension? One could double-click on a button, for example, and that might cause confusion for a browser extension.**

FYI: @HunnySajid

edeykholt commented 3 weeks ago

Similar issue on https://reg-pilot-webapp-test.rootsid.cloud/status page, which waits for the extension to sign the request headers. What should happen when the user chooses not to do this, or accidentally clicks off or closes the popup or dialog?
Expected: polaris-web should have ability to receive a cancel message. Polaris-web should timeout after waiting a long time, and stop the waiting/spinning.

HunnySajid commented 2 weeks ago

The cancle from dialog case has been handled here

https://github.com/WebOfTrust/signify-browser-extension/pull/225 with a pr to handle errors thrown by extension in case of close dialog

https://github.com/GLEIF-IT/reg-pilot-webapp/pull/108

Video Illustration:

https://github.com/user-attachments/assets/970cd773-0bd3-4f11-91f1-a58c0f66245f