search

GLEON / glmtools

Tools for interacting with the General Lake Model (GLM) in R
Other
22 stars 31 forks source link

Package cleanup #228

Closed jsta closed 7 years ago

jsta commented 7 years ago

I plan on submitting a PR with changes similar to those discussed at: https://github.com/GLEON/GLMr/issues/113

jsta commented 7 years ago

One thing I notice right away is that very few (none?) of the examples are set to dontrun. This makes running devtools::check() very slow. What do you think about setting dontrun on some of them?

lawinslow commented 7 years ago

But having them run means they actually act as a verification that the package is not broken.

jsta commented 7 years ago

Hmm, I wonder if there is a way to make things faster then without dontrun. I notice that all of the examples have the line:

sim_folder <- run_example_sim(verbose = FALSE)

Maybe moving package verification to tests would allow this line to be run only once (or at least fewer times) during checking?

lawinslow commented 7 years ago

I have no issue moving things into testthat, but @jread-usgs is jury and judge for this package, so it's primarily up to him

jsta commented 7 years ago

I found out that the following command will run check without executing the examples:

devtools::check(args = "--no-examples")