GLEON / glmtools

Tools for interacting with the General Lake Model (GLM) in R
Other
22 stars 31 forks source link

Create error, warning, or ignore system for nml params that conflict #261

Open jordansread opened 4 years ago

jordansread commented 4 years ago

It seems failing early on setting params incorrectly would be helpful for users, especially with GLM errors aren't the easiest to track down. Starting with really simple ones first to create a pattern for implementing these rules would be ideal, making it easier for others to propose and implement more complex ones in the future.

For the time being, I am thinking about a couple of things:

Seems like a good starting point. Would be nice to be able to avoid errors or warnings if you want, so that should be coded in the validation checker.

jordansread commented 3 years ago

Another tricky one that will cause a GLM v3.1 segfault but not let you know why: when crest_elev is below the bottom of H