Closed boshek closed 6 years ago
@boshek Awesome contribution. Thanks! I'll review this later today or tomorrow so we can get this in and onto CRAN soon!
I have a small vignette that I will expand in rmarkdown. Have you ever considered that format for vignettes? Currently checked out of the repo because it is arguing too much with TRAVIS
Definitely interested in vignettes. Don't care about the format. The only reason we have legacy format documentation is that this is an old package started before those other things were popular (or even existed). It would be great to include.
With respect to vignettes I will have to submit that as a separate pull request because I think having two vignette builders would be a hassle.
Separate PR for vignette makes sense. The rest of this looks awesome. Thanks!
The split and merge algorithm is a method to auto-detect layers in the water column. Key considerations/conversations prior to merging:
wtr_layer()
make sense in the context all the other functions in this package? It currently outputs the mix layer depth, a cline (depending on what parameter is chosen) and the segments calculated as a list column. This is a handy was to store data is different [i,j] inside the same dataframe. Consider this example:latesummer
into the packageTechnique and limnological references