GLEON / rLakeAnalyzer

An R version of Lake Analyzer
43 stars 26 forks source link

Merging in split and merge algorithm #85

Closed boshek closed 6 years ago

boshek commented 6 years ago

The split and merge algorithm is a method to auto-detect layers in the water column. Key considerations/conversations prior to merging:

Technique and limnological references

lawinslow commented 6 years ago

@boshek Awesome contribution. Thanks! I'll review this later today or tomorrow so we can get this in and onto CRAN soon!

lawinslow commented 6 years ago

I have a small vignette that I will expand in rmarkdown. Have you ever considered that format for vignettes? Currently checked out of the repo because it is arguing too much with TRAVIS

Definitely interested in vignettes. Don't care about the format. The only reason we have legacy format documentation is that this is an old package started before those other things were popular (or even existed). It would be great to include.

boshek commented 6 years ago

With respect to vignettes I will have to submit that as a separate pull request because I think having two vignette builders would be a hassle.

lawinslow commented 6 years ago

Separate PR for vignette makes sense. The rest of this looks awesome. Thanks!