GLIMS-RGI / rgi7_scripts

Collection of scripts used for the generation of the RGI version 7 - WIP
BSD 3-Clause "New" or "Revised" License
8 stars 9 forks source link

Glacier complex product with precision model? #74

Closed fmaussion closed 1 year ago

fmaussion commented 1 year ago

Sometimes the glacier complex product looks like this:

image

if you zoom in, you see that the outlines are "close", but not quite:

image

Maybe this can be solved with a precision model, maybe not...

iamdonovan commented 1 year ago

I think this should be possible using shapely.ops.snap(), right?

fmaussion commented 1 year ago

I did not know about this, that's great! It looks like one needs to identify the two geometries to snap first, which suggests we should do it on all the geometries even if they don't need it. That's probably okay.

So the workflow would be:

I think this might help with case 1 (green in the picture below) but it still wont solve 2 (red in the picture below) where there is no way to know that the two geometries are so close. The red circle case would imply adding a 4th step which looks for nearby geometries if they can be snapped, but this looks tedious and error prone...

Thoughts?

image

fmaussion commented 1 year ago

Snap did not work well :laughing:

image

Issue now reported here, wont be fixed in RGI7: https://github.com/GLIMS-RGI/rgi_issue_tracker/issues/21