search

GLL-Better / opendata

Documentation, Changelog and Issues related to the GLL RPDE endpoint
1 stars 1 forks source link

Welsh locations #30

Open GetTheData opened 4 years ago

GetTheData commented 4 years ago

Hi @GLL-Digital

I'm seeing what I think are identical Welsh locations duplicated in the feed under their English and Welsh names. They have different items under each name.

Example 1:

Example 2:

Cheers Dan

itsterry commented 4 years ago

Hi @GetTheData

They have different items under each name? That's worrying! Can you send me an example, please, so I can diagnose?

T

GetTheData commented 4 years ago

Hi @itsterry

Here are my listings for each:

You can hopefully see that the listings are similar, but not identical. Sometimes the name is different, sometimes there is an extra session under one location but not another.

Here are two sessions which appear to be the same session but with different names:

https://www.getthedata.com/openactive/event/459330284 [ID:46618648] https://www.getthedata.com/openactive/event/461377447 [ID:46627262]

Let me know if you need any more info and I'll pull it out.

Cheers Dan

itsterry commented 4 years ago

Those two sessions are in the same pool at the same time, but they're different. It happens when part of a pool is laned off for length-swimmers and the rest of the pool is left open for everyone else. 2 activities taking place side by side

Star Hub Timetable Cardiff Better

GetTheData commented 4 years ago

Thanks @itsterry that makes sense.

Here is an example of a missing session:

https://www.getthedata.com/openactive/event/315190789 [ID: 45187221]

This is in the Pentwyn Leisure Centre feed but not the Canolfan Hamdden Pentwyn feed.

Cheers Dan

itsterry commented 4 years ago

Confirming: there are sessions which have been put in against the English version, but not the Welsh version - I'm guessing those are English-only sessions (joking...)

How would it play if I only included the English-version venues in the feed?

GetTheData commented 4 years ago

@itsterry Haha!

How would it play if I only included the English-version venues in the feed?

That would be fine by me.

I gave this some thought and concluded that the issue should go back to Open Active to see if they might accommodate multiple languages in a future version of the spec. One for @nickevansuk perhaps?

In the meantime, I would personally prefer not to have the duplication but I can easily handle that at my end if necessary by suppressing one of the locations.

Cheers Dan