globaleaks / globaleaks-whistleblowing-software

GlobaLeaks is free, open-source whistleblowing software enabling anyone to easily set up and maintain a secure reporting platform.
https://www.globaleaks.org
Other
1.23k stars 269 forks source link

#4116:Display report expiration date changes #4123

Closed obinnaeye closed 2 months ago

obinnaeye commented 3 months ago

Before you submit a pull request, please make sure:

See https://github.com/globaleaks/GlobaLeaks/issues/4116

Steps to Test Locally:

  1. Checkout this branch feature/4116-display-report-expiration-changes
  2. Build client code: cd client && ./node_modules/grunt/bin/grunt build
  3. Start server: `cd backend && bin/globaleaks -z -n
  4. Go to https://127.0.0.1:8443
  5. Log into a recipient dashboard
  6. Update a report expiration date
  7. Confirm a new comment added to the report

Screeshots:

Screenshot from 2024-07-03 21-38-48 Screenshot from 2024-07-03 21-38-59

TODO:

Add these proposed API tests for these two endpoints: /api/recipient/rtips/{id}/comments and /api/whistleblower/wbtip/comments.

  1. Assert that a comment is added for every change in expiration date.
  2. Assert that the comments are visible on both the recipient's and whistleblower's reports.
  3. Assert that auditlog-related comments contain all the fields, including is_audit_log and audit_log_type.
obinnaeye commented 3 months ago

While working on this ticket, I found a bug and have filed it https://github.com/globaleaks/GlobaLeaks/issues/4124

evilaliv3 commented 2 months ago

Thank you @obinnaeye for your contribution!

I'm going to integrated it on top of the devel branch and perform a minor revision.