search

GLOBALEAKS / globaleaks-whistleblowing-software

GlobaLeaks is free, open-source whistleblowing software enabling anyone to easily set up and maintain a secure reporting platform.
https://www.globaleaks.org
Other
1.23k stars 269 forks source link

Customized sub-status expiring days not working #4177

Closed larrykind closed 1 month ago

larrykind commented 1 month ago

What version of GlobaLeaks are you using?

4.15.5

What browser(s) are you seeing the problem on?

All

What operating system(s) are you seeing the problem on?

Linux

Describe the issue

If a new sub-status is created using the feature "Set expire after X days" it seems to be not working, the report is always there and logs are not showing as usual the row "XX-XX-2024 02:00 | delete_report | system". The channel used for the report has a default expiration set after 5 years.

Proposed solution

No response

evilaliv3 commented 1 month ago

Thank you @larrykind

I've fixed this issue and i'm about to release a 5.0.3 including the correction.

We are not considering issuing fixes for previous releases but if you need to fix your setup you could manually apply the same patch.

larrykind commented 1 month ago

Thank you @evilaliv3. After the patch was applied, what will happen to reports that are supposed to be deleted in the days before? Will they be deleted anyway?

evilaliv3 commented 1 month ago

Thank you @larrykind for your question.

Since the bug was in place, it was not possible for users to change the status of the report.

evilaliv3 commented 1 month ago

Fixed and fix included in release 5.0.3

larrykind commented 1 month ago

hi @evilaliv3 tested also with 5.0.4 but unfortunately it seems to not work. That's the test I did:

I noticed that:

  1. Every substatus, included "Closed" substatuses can only be created from tenant's admin and not from general admin, if it's created from general admin, tenant's tab logs out.
  2. After substatus with customized expire was created, saving the parent status gives a red label "Error" , not logged.
evilaliv3 commented 1 month ago

Tank you @larrykind

Actually i confirm the errors as for points 1. and 2. in your comment that will be fixed in release 5.0.6 but the feature seems to work as expected in the other situations.

I suggest you to retry on 5.0.6