GLOBALEAKS / globaleaks-whistleblowing-software

GlobaLeaks is free, open-source whistleblowing software enabling anyone to easily set up and maintain a secure reporting platform.
https://www.globaleaks.org
Other
1.23k stars 269 forks source link

Closed and reopend reports are not automatically deleted #4192

Closed eleibr closed 1 week ago

eleibr commented 4 weeks ago

What version of GlobaLeaks are you using?

4.15.9

What browser(s) are you seeing the problem on?

All

What operating system(s) are you seeing the problem on?

Windows, iOS

Describe the issue

When the report status is changed to closed or a closed report is reopened, it remains on the platform also after the expiration date. The automatic e-mail notification with the reminder of expiration is not sent.

In the Changelog I can see that the reopening issue was fixed in 4.15.9, but this doesn't work for me. Could this be related to the issue I reported last month? https://github.com/globaleaks/whistleblowing-software/issues/4158#issuecomment-2301243390

And what about the closed report not deleted? I cannot find documentation about this but I presume that it should be automatically deleted on the expiration date. Is this a bug?

Thanks

Proposed solution

No response

evilaliv3 commented 4 weeks ago

@eleibr

If yuo close a report, and then re-open the report the expiration date of the report is set as new.

For example, suppose you have a data retention policy of 3 months, and that the report is about to expire today. If you today close the report and re-open it, the data retention policy will be set to 3 months from today.

Does it work for you? Do you have any suggestion?

This current behavious is based on consideration made with @giorgiofraschini @elbill @larrykind

larrykind commented 4 weeks ago

I think this should be the right behaviour: the retention should be calculated from the last report update date. If the receiver needs to make it expire before, it should be set a custom expire closed substatus to it.

eleibr commented 3 weeks ago

Thank you for your kind reply. I've made some more tests and I can confirm that it works. The problem was related to an automatic shutdown of the server during the night, so that the scheduled job to delete reports was not activated.

evilaliv3 commented 1 week ago

Thank you for your feedback! Closing the ticket as addressed.