Checking map type before determining value range

GLVis / glvis

Lightweight OpenGL tool for accurate and flexible finite element visualization

http://glvis.org

BSD 3-Clause "New" or "Revised" License

249 stars 51 forks source link

Closed mlstowell closed 1 year ago

mlstowell commented 1 year ago

This PR allows GLVis to determine the range, for use in the color bar, when displaying scalar fields with map type INTEGRAL.

This PR partially addresses issue #248

Note: this branch depends on an MFEM branch of the same name.

mlstowell commented 1 year ago

This PR introduces a segfault in some of the tests. I'll track it down.

tzanio commented 1 year ago

This PR introduces a segfault in some of the tests. I'll track it down.

I haven't check this PR, but wanted to mention that there could be CI issues from the switch to macos-latest in this repo, see here.

tzanio commented 1 year ago

This should be merged after https://github.com/mfem/mfem/pull/3349 is merged and this change is reverted.

tzanio commented 1 year ago

@mlstowell, now that https://github.com/mfem/mfem/pull/3349 is merged, can you switch to master in this PR?