search

GLVis / pyglvis

GLVis Jupyter Widget
BSD 3-Clause "New" or "Revised" License
12 stars 3 forks source link

Question about MFEM wrapper version used in notebooks #19

Closed sshiraiwa closed 2 years ago

sshiraiwa commented 2 years ago

PyMFEM version 4.3.0.0 is out and I noticed mfem wrapper loaded in notebook is still 4.2.0.16. I incremented the version written in https://github.com/mfem/PyMFEM/blob/master/binder/requirements.txt. But, this does not (perhaps obviously) impact the notebook under here. Where is the version requirement encoded?

tzanio commented 2 years ago

We should probably increment also here: https://github.com/GLVis/pyglvis/blob/master/requirements.txt

tzanio commented 2 years ago

@tomstitt, can you help?

tomstitt commented 2 years ago

We should also probably increment also here: https://github.com/GLVis/pyglvis/blob/master/requirements.txt

@tzanio you are correct! I'm happy to bump it

edit: done