GLYCAM-Web / gmml

Glycam Molecular Modeling Library
GNU Lesser General Public License v3.0
4 stars 10 forks source link

Test level caught exception: Could not find prep entry for DNeu5Ac Glycam: 0Sa #104

Closed gitoliver closed 1 year ago

gitoliver commented 2 years ago

Test level caught exception: Could not find prep entry for DNeu5Ac Glycam: 0Sa The code should not look for prep files if there is no ring form specified (f or p). The error should be something like: "Ring form not specified in input residue >>>DNeu5Ac<<<".

Lachele commented 2 years ago

Rob requested that NeuNAc and Neu5Ac be accepted as input. The rationale is that these terms are widely used and that the alternate forms (L, p, f) are not generally found in mammalian systems. One of the ideas behind a generic 'sequence' component in GMML is that these bespoke translations can happen there and the real parsing can happen later. I'm not altogether opposed to forcing folks to specify isomer and ring form, but the sequence "DNeu5Aca2-OH" is valid on Actual at glycam.org/txt.

On Fri, Oct 8, 2021 at 5:03 AM gitoliver @.***> wrote:

Test level caught exception: Could not find prep entry for DNeu5Ac Glycam: 0Sa The code should not look for prep files if there is no ring form specified (f or p). The error should be something like: "Ring form not specified in input residue >>>DNeu5Ac<<<".

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GLYCAM-Web/gmml/issues/104, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCV7D4XGSRIGMCXIHRH7GDUF2XVVANCNFSM5FTEENSQ .

-- :-) Lachele @.*** lachelefoley.com Note that lachelefoley.com is down. There was a server thing. After I finish writing 3 of the dozen papers I need to write, I'll put it back up.

gitoliver commented 1 year ago

Not doing this. DNeupNAcb2-OH or DNeup5Acb2-OH is acceptable input, not specifying the ring form will throw an error.