search

GLYCAM-Web / gmml

Glycam Molecular Modeling Library
GNU Lesser General Public License v3.0
4 stars 10 forks source link

Sequences with unnecessary brackets do not fail well e.g. [LFucp[2Me,4A]a1-2]DGalpb1-OH #135

Open gitoliver opened 2 years ago

gitoliver commented 2 years ago

Build via text and put [LFucp[2Me,4A]a1-2]DGalpb1-OH The Gal isn't generated, instead you get LFucp[2Me,4A]a1-OH, which is not what I would expect. Either the brackets should be ignored, or an error thrown. Low priority as the inputs are technically flawed.

Lachele commented 2 years ago

I vote for ignoring the extraneous brackets. That sort of thing could easily happen from editing another sequence. I see no reason to punish people for it. I agree this is a low priority.

On Tue, Mar 29, 2022 at 4:03 AM Oliver @.***> wrote:

Build via text and put [LFucp[2Me,4A]a1-2]DGalpb1-OH The Gal isn't generated, instead you get LFucp[2Me,4A]a1-OH, which is not what I would expect. Either the brackets should be ignored, or an error thrown. Low priority as the inputs are technically flawed.

— Reply to this email directly, view it on GitHub https://github.com/GLYCAM-Web/gmml/issues/135, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCV7DZGVCWVVW2KFKA45H3VCK2OPANCNFSM5R5RXKIA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- :-) Lachele @.*** lachelefoley.com Note that lachelefoley.com is down. There was a server thing. After I finish writing 3 of the dozen papers I need to write, I'll put it back up.

gitoliver commented 2 years ago

Just noting that it happened as the user was trying to build in the opposite direction. So they clicked Gal first, then OH, and then their only option for adding Fuc was as a branch... So I wonder if we can design the interface better that this doesn't happen. Anyway it would still be ideal if gmml would figure out that the brackets are extraneous by itself, so I'll keep this open as an "enhancement".