GLYCAM-Web / gmml

Glycam Molecular Modeling Library
GNU Lesser General Public License v3.0
4 stars 10 forks source link

Version File Cruft Removal #151

Closed Pshepp closed 1 year ago

Pshepp commented 1 year ago

The use of the make-versions-file.bash script within the programs dir is a bit silly. No need for the extra complexity

Steps to fix:

gitoliver commented 1 year ago

Is this a gmml issue or higher up?

Lachele commented 1 year ago

This is how we build the info that goes into https://glycam.org/status/versions/

I wrote it so that each repo creates and maintains its own versioning info. Each higher (gems, website) version of that script calls and collects output from lower versions.

The git hashes of the actual code being used are much more precise and reliable than any versioning scheme, so I do not want to let them go, even when we implement a more standard versioning.

gitoliver commented 1 year ago

Sounds like it should stay.