GLYCAM-Web / website

A bare-bones repo to contain public website stuff and issues related to the GLYCAM Web Django apps.
4 stars 0 forks source link

Linkage metadata isn't updated in root to leaf builder when you change from f to p ring types. #102

Open gitoliver opened 1 year ago

gitoliver commented 1 year ago

Tool: Root to leaf carbohydrate builder

Bug Description: Fixture data for Ara is:

{
    "model": "cb.residuebutton",
    "pk": 12,
    "fields": {
        "name": "Ara",
        "isomer_default": "D",
        "isomer2": "L",
        "ring_type_default": "p",
        "ring_type2": "f",
        "configuration_default": "a",
        "configuration2": "b",
        "linkage": 1,
        "positions_1": "1,2,3,4",
        "positions_2": "1,2,3,5",
        "template": "full"
    }
},

but when I click Ara and then f for ring type for both monosaccharides of a disaccharide, I can only select 1-2, 1-3, and 1-4 connections. The metadata is correct, but the website isn't using it. When the ring type is f, the connections should be 1-2, 1-3 and 1-5.

To Reproduce: Click Ara (or whatever) and change the ring type from f to p or vice versa.

Expected behavior The options should match the metadata.

Additional context From Dan: Best I can tell, this logic was never added to the tool.

cexum commented 1 year ago

Dan says: "Meta-data needs to be immutable. It currently is not. What needs updating here is the list of enabled linkages, after a user changes a ring type."

gitoliver commented 2 months ago

Still an issue.