search

GLYCAM-Web / website

A bare-bones repo to contain public website stuff and issues related to the GLYCAM Web Django apps.
4 stars 0 forks source link

CB Polling Requests and Response delay causes backward progress indication #160

Open danwentworthart opened 8 months ago

danwentworthart commented 8 months ago

Tool: CB Downloads polling logic

Bug Description: Polling needs to become more sophisticated. The motivation behind this issue is we want speed, so we send many requests until we get the status response "All Complete." The problem that arises is responses are not guaranteed to return in the same order they were sent out, so a "Minimizing" status can get hung up somehow and return after we progress to "2 of 3" or "All Complete".

To Reproduce: This existing ticket already describes how to reproduce this issue. The bug it describes doesn't occur anymore, but if you watch the status field while you wait, you will see conformers advance, and then return to "minimizing" when they really should not.

https://github.com/GLYCAM-Web/website/issues/119

Expected behavior Once we advance past "minimizing" or any status, really, we should not move backward. Add logic to make sure laggard responses are just ignored.

danwentworthart commented 1 week ago

Seems to have found its way onto test.glycam.org. I swear I fixed this, but apparently need to revisit this again.