search

GLYCAM-Web / website

A bare-bones repo to contain public website stuff and issues related to the GLYCAM Web Django apps.
4 stars 0 forks source link

Errors during initial git ops should be fatal but aren't #161

Open Lachele opened 10 months ago

Lachele commented 10 months ago

Tool: Developer Platform

Bug Description: A git ops error that should have been fatal was not. The GMML repo could not update, but the startup continued on. The git ops can, of course, be skipped if a dev expects failure and needs to tolerate it.

To Reproduce:

  1. Take down your DevEnv in case of chaos. Or use a separate install (a separate user or VM, etc., is recommended).
  2. Add a bogus refspec, or some other failure-inducing problem, to your .git/config in the GMML repo
  3. Run the start all script.
  4. Look at the initial output during startup. In mine, there was an error (below), but execution did not halt.

I expect that the other repos behave the same, but I didn't test.

Expected behavior I expect that an update-the-source-code error should stop execution of the start all script.

Additional context I was trying to update my DevEnv from an installation that had not been updated in a while. I kept getting errors. That wasn't a surprise. But, I finally noticed, as it flew past, that GMML was not updating. See message below. I can fix the remote refs problem, but I think startup of the DevEnv should halt if any of these git ops fails.

This shouldn't be very hard to do. Whoever is in there first and has the bandwidth, please do it.

Attempting to update the gmml repo.
Executing:
( cd ./Web_Programs/gems/gmml && git branch -u origin/gmml-test && git pull )
Branch 'gmml-test' set up to track remote branch 'gmml-test' from 'origin'.
fatal: couldn't find remote ref refs/heads/firstExternLibNormalization_preston

Error!  Unable to update the repo.
You can try again on your own using the command below.

( cd ./Web_Programs/gems/gmml           && git branch -u origin/gmml-test               && git pull )