search

GLab / ToMaTo

German-Lab ToMaTo
http://www.tomato-lab.org
32 stars 21 forks source link

tech/type inconsistency #1460

Closed a-gerhard closed 7 years ago

a-gerhard commented 7 years ago

We have an inconsistency in the naming of tech and type.

previously, we only differentiated 'techs' (OpenVZ, KVMQM, Repy) now, we differentiate types (Container, Full, Repy) and their individual techs (OpenVZ, LXC, KVMQM, KVM).

currently, profiles and templates use a "tech" field to reference to their type on the backend. On hostmanagers, the templates' "tech" field references actual techs.

To avoid confusion, I suggest that we rename the respective fields in the backend and frontend code.

While doing this, we should also develop a better concept of templates: do we only allow generic templates for each tech, or can we have separate image files per template for individual techs? Maybe we could put all types and techs into one template (and disable some types/techs for templates completely) - but then we might need alternative descriptions in some cases

a-gerhard commented 7 years ago

FYI: I found some references regarding tech in templates at the following places: https://github.com/GLab/ToMaTo/blob/master/web/tomato/templates/web_resources/default_executable_archive_info.html#L75 https://github.com/GLab/ToMaTo/blob/master/web/tomato/js/editor/windows/default_executable_archive_detail_window.js